chore: follow-up fixes from develop commit review#11966
Open
Planeshifter wants to merge 3 commits intodevelopfrom
Open
chore: follow-up fixes from develop commit review#11966Planeshifter wants to merge 3 commits intodevelopfrom
Planeshifter wants to merge 3 commits intodevelopfrom
Conversation
The benchmark double-wrapped the input list and used a `Layout` type assertion that diverges from the declared `Order` return type. Pass the inner list of ndarrays directly, add the missing argument-spacing in `array()` calls, and align the type-test annotation with the declaration.
Rename the import alias `consensusLayout` to the canonical `consensusOrder` and update the `$ExpectType` annotation from `Layout` to `Order` so the type test matches the function declaration.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
`eslint-plugin-expect-type` resolves transparent type aliases when reporting the inferred return type. Because `Order = Layout` in `@stdlib/types/ndarray`, the plugin always reports `Layout` and the `$ExpectType Order` annotation fails the lint check.
Planeshifter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-05-05 15:11 PT and 2026-05-06 04:46 PT (range74e79f9..1481c95, 25 commits, 121 files) with high-signal corrections to the two newndarray/basepackages introduced in the window.Fixes grouped by package:
ndarray/base/output-order(commit52bc84e)lib/node_modules/@stdlib/ndarray/base/output-order/benchmark/benchmark.js(52bc84e) where the loop body erroneously wrappedarr[ i%arr.length ]in an extra array literal, causingoutputOrderto receive[ [ ndA, ndB ] ]and always fall back to the default order; drop the outer brackets so the benchmark exercises the intended code path.lib/node_modules/@stdlib/ndarray/base/output-order/benchmark/benchmark.js(52bc84e): threearray()calls were missing the required space before the closing parenthesis per the stdlib style guide.$ExpectTypeannotation inlib/node_modules/@stdlib/ndarray/base/output-order/docs/types/test.ts(52bc84e):Layoutwas incorrect; return type isOrder, consistent withndarray/base/orderconventions.ndarray/base/consensus-order(commitb3ec3d3)lib/node_modules/@stdlib/ndarray/base/consensus-order/docs/types/test.ts(b3ec3d3): rename copy-paste aliasconsensusLayouttoconsensusOrderand correct$ExpectTypeannotation fromLayouttoOrder.Related Issues
None.
Questions
No.
Other
Validation. The window's union diff was scanned by four independent reviewers (two style-guide compliance audits against
docs/style-guidesand reference packagesndarray/base/order/blas/base/ndarray/dscal; two bug audits — one diff-only, one logic/security on the introduced code). Only findings that were either reported by two or more reviewers or independently re-verifiable from the diff were retained.Deliberately excluded.
to-reversed-dimensions/README.md<related-links>placeholder comments: verified false positive — those markers are an established stdlib convention present in 29 otherndarray/basepackages.consensus-order/package.jsondescription ("Resolve the most common underlying storage layout."): subjective; the description is a complete sentence and not a clear style violation.API_SUFFIXwrapper fixes, internal-utility replacements inblas/ext/{linspace,unitspace}andndarray/concat*: reviewed and confirmed correct.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was prepared by Claude Code: a multi-agent review of commits merged to
developin the previous 24 hours surfaced the high-signal issues, and the fixes were applied programmatically. Each finding was cross-validated by at least two reviewers or independently re-verified against the diff before inclusion.Generated by Claude Code